[PATCH] D146720: [AMDGPU][printf] Run AMDGPUPrintfRuntimeBindingPass in -O0

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/opt-pipeline.ll:18
+;GCN-O0-NEXT: Running pass: AlwaysInlinerPass on [module]
+;GCN-O0-NEXT: Running analysis: ProfileSummaryAnalysis on [module]
+;GCN-O0-NEXT: Running pass: CoroConditionalWrapper on [module]
----------------
arsenm wrote:
> arsenm wrote:
> > jmmartinez wrote:
> > > I have the feeling that I should remove analysis and analysis invalidations from the list.
> > Depends, do theses passes actually do anything? I don’t know what CoroConditionalWrappper does 
> By remove I thought you meant stop the pass from running. In terms of testing, I expect every single pass run to be tested here and every check use -NEXT
Oh sorry, I actually meant the removing the "Running analysis" and "Invalidating analysis" entries, such that only the code transformation are checked. And, since I removed the analysis entries, I've added the I've added the `--implicit-check-not="Running pass"` flag instead of using `CHECK-NEXT`.

I can revert these changes if you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146720/new/

https://reviews.llvm.org/D146720