[llvm] 90eab48 - [Test] Use autogenerated checks in uglygep.ll test for LSR (NFC)
Dmitry Makogon via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 24 04:47:37 PDT 2023
Author: Dmitry Makogon
Date: 2023-03-24T18:28:29+07:00
New Revision: 90eab480a91c720cdb16012075f1ae3af1d4ea75
URL: https://github.com/llvm/llvm-project/commit/90eab480a91c720cdb16012075f1ae3af1d4ea75
DIFF: https://github.com/llvm/llvm-project/commit/90eab480a91c720cdb16012075f1ae3af1d4ea75.diff
LOG: [Test] Use autogenerated checks in uglygep.ll test for LSR (NFC)
Added:
Modified:
llvm/test/Transforms/LoopStrengthReduce/uglygep.ll
Removed:
################################################################################
diff --git a/llvm/test/Transforms/LoopStrengthReduce/uglygep.ll b/llvm/test/Transforms/LoopStrengthReduce/uglygep.ll
index aeacd3daf1e48..a0df9078bd82d 100644
--- a/llvm/test/Transforms/LoopStrengthReduce/uglygep.ll
+++ b/llvm/test/Transforms/LoopStrengthReduce/uglygep.ll
@@ -1,3 +1,4 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
; RUN: opt -opaque-pointers=0 < %s -loop-reduce -S | FileCheck %s
; LSR shouldn't consider %t8 to be an interesting user of %t6, and it
@@ -5,8 +6,35 @@
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
+; Check that LSR hoists %t2 computation outside the loop,
+; folds %t3's add within the address
+; and uses the induction variable (%t4) to access the right element.
define void @test(i8* %ptr.i8, float** %ptr.float) {
-; CHECK-LABEL: define void @test(
+; CHECK-LABEL: define void @test
+; CHECK-SAME: (i8* [[PTR_I8:%.*]], float** [[PTR_FLOAT:%.*]]) {
+; CHECK-NEXT: bb:
+; CHECK-NEXT: br label [[BB3:%.*]]
+; CHECK: bb1:
+; CHECK-NEXT: br i1 true, label [[BB10:%.*]], label [[BB2:%.*]]
+; CHECK: bb2:
+; CHECK-NEXT: [[T:%.*]] = add i64 [[T4:%.*]], 1
+; CHECK-NEXT: br label [[BB3]]
+; CHECK: bb3:
+; CHECK-NEXT: [[T4]] = phi i64 [ [[T]], [[BB2]] ], [ 0, [[BB:%.*]] ]
+; CHECK-NEXT: br label [[BB1:%.*]]
+; CHECK: bb10:
+; CHECK-NEXT: [[T7:%.*]] = icmp eq i64 [[T4]], 0
+; CHECK-NEXT: [[SCEVGEP:%.*]] = getelementptr i8, i8* [[PTR_I8]], i64 [[T4]]
+; CHECK-NEXT: br label [[BB14:%.*]]
+; CHECK: bb14:
+; CHECK-NEXT: store i8 undef, i8* [[SCEVGEP]], align 1
+; CHECK-NEXT: [[T6:%.*]] = load float*, float** [[PTR_FLOAT]], align 8
+; CHECK-NEXT: [[SCEVGEP1:%.*]] = getelementptr float, float* [[T6]], i64 4
+; CHECK-NEXT: [[SCEVGEP12:%.*]] = bitcast float* [[SCEVGEP1]] to i8*
+; CHECK-NEXT: [[SCEVGEP3:%.*]] = getelementptr i8, i8* [[SCEVGEP12]], i64 [[T4]]
+; CHECK-NEXT: store i8 undef, i8* [[SCEVGEP3]], align 1
+; CHECK-NEXT: br label [[BB14]]
+;
bb:
br label %bb3
@@ -21,26 +49,11 @@ bb3: ; preds = %bb2, %bb
%t4 = phi i64 [ %t, %bb2 ], [ 0, %bb ] ; <i64> [#uses=3]
br label %bb1
-; CHECK: bb10:
-; CHECK-NEXT: %t7 = icmp eq i64 %t4, 0
-; Host %t2 computation outside the loop.
-; CHECK-NEXT: [[SCEVGEP:%[^ ]+]] = getelementptr i8, i8* %ptr.i8, i64 %t4
-; CHECK-NEXT: br label %bb14
bb10: ; preds = %bb9
%t7 = icmp eq i64 %t4, 0 ; <i1> [#uses=1]
%t3 = add i64 %t4, 16 ; <i64> [#uses=1]
br label %bb14
-; CHECK: bb14:
-; CHECK-NEXT: store i8 undef, i8* [[SCEVGEP]]
-; CHECK-NEXT: %t6 = load float*, float** %ptr.float
-; Fold %t3's add within the address.
-; CHECK-NEXT: [[SCEVGEP1:%[^ ]+]] = getelementptr float, float* %t6, i64 4
-; CHECK-NEXT: [[SCEVGEP2:%[^ ]+]] = bitcast float* [[SCEVGEP1]] to i8*
-; Use the induction variable (%t4) to access the right element
-; CHECK-NEXT: [[ADDRESS:%[^ ]+]] = getelementptr i8, i8* [[SCEVGEP2]], i64 %t4
-; CHECK-NEXT: store i8 undef, i8* [[ADDRESS]]
-; CHECK-NEXT: br label %bb14
bb14: ; preds = %bb14, %bb10
%t2 = getelementptr inbounds i8, i8* %ptr.i8, i64 %t4 ; <i8*> [#uses=1]
store i8 undef, i8* %t2
@@ -51,16 +64,47 @@ bb14: ; preds = %bb14, %bb10
br label %bb14
}
+; Check that induction variable is initialized to -2.
+; IVNEXT covers the uses of %i0 and %t0.
+; Therefore, %t0 should be removed and the critical edge must be split.
define fastcc void @TransformLine() nounwind {
-; CHECK-LABEL: @TransformLine(
+; CHECK-LABEL: define fastcc void @TransformLine
+; CHECK-SAME: () #[[ATTR0:[0-9]+]] {
+; CHECK-NEXT: bb:
+; CHECK-NEXT: br label [[LOOP0:%.*]]
+; CHECK: loop0:
+; CHECK-NEXT: [[LSR_IV:%.*]] = phi i32 [ [[LSR_IV_NEXT:%.*]], [[LOOP0]] ], [ -2, [[BB:%.*]] ]
+; CHECK-NEXT: [[LSR_IV_NEXT]] = add nuw nsw i32 [[LSR_IV]], 1
+; CHECK-NEXT: br i1 false, label [[LOOP0]], label [[BB0:%.*]]
+; CHECK: bb0:
+; CHECK-NEXT: br label [[LOOP1:%.*]]
+; CHECK: loop1:
+; CHECK-NEXT: [[I1:%.*]] = phi i32 [ 0, [[BB0]] ], [ [[I1_NEXT:%.*]], [[BB5:%.*]] ]
+; CHECK-NEXT: br i1 false, label [[BB2:%.*]], label [[LOOP1_BB6_CRIT_EDGE:%.*]]
+; CHECK: bb2:
+; CHECK-NEXT: br i1 true, label [[BB6SPLITSPLIT:%.*]], label [[BB5]]
+; CHECK: bb5:
+; CHECK-NEXT: [[I1_NEXT]] = add i32 [[I1]], 1
+; CHECK-NEXT: br i1 true, label [[BB5_BB6SPLIT_CRIT_EDGE:%.*]], label [[LOOP1]]
+; CHECK: bb5.bb6split_crit_edge:
+; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[LSR_IV_NEXT]], [[I1_NEXT]]
+; CHECK-NEXT: br label [[BB6SPLIT:%.*]]
+; CHECK: bb6splitsplit:
+; CHECK-NEXT: br label [[BB6SPLIT]]
+; CHECK: bb6split:
+; CHECK-NEXT: [[P8_PH:%.*]] = phi i32 [ [[TMP0]], [[BB5_BB6SPLIT_CRIT_EDGE]] ], [ undef, [[BB6SPLITSPLIT]] ]
+; CHECK-NEXT: [[P9_PH:%.*]] = phi i32 [ undef, [[BB5_BB6SPLIT_CRIT_EDGE]] ], [ [[I1]], [[BB6SPLITSPLIT]] ]
+; CHECK-NEXT: br label [[BB6:%.*]]
+; CHECK: loop1.bb6_crit_edge:
+; CHECK-NEXT: br label [[BB6]]
+; CHECK: bb6:
+; CHECK-NEXT: [[P8:%.*]] = phi i32 [ undef, [[LOOP1_BB6_CRIT_EDGE]] ], [ [[P8_PH]], [[BB6SPLIT]] ]
+; CHECK-NEXT: [[P9:%.*]] = phi i32 [ [[I1]], [[LOOP1_BB6_CRIT_EDGE]] ], [ [[P9_PH]], [[BB6SPLIT]] ]
+; CHECK-NEXT: unreachable
+;
bb:
br label %loop0
-; CHECK: loop0:
-; Induction variable is initialized to -2.
-; CHECK-NEXT: [[PHIIV:%[^ ]+]] = phi i32 [ [[IVNEXT:%[^ ]+]], %loop0 ], [ -2, %bb ]
-; CHECK-NEXT: [[IVNEXT]] = add nuw nsw i32 [[PHIIV]], 1
-; CHECK-NEXT: br i1 false, label %loop0, label %bb0
loop0: ; preds = %loop0, %bb
%i0 = phi i32 [ %i0.next, %loop0 ], [ 0, %bb ] ; <i32> [#uses=2]
%i0.next = add i32 %i0, 1 ; <i32> [#uses=1]
@@ -69,52 +113,18 @@ loop0: ; preds = %loop0, %bb
bb0: ; preds = %loop0
br label %loop1
-; CHECK: loop1:
-; CHECK-NEXT: %i1 = phi i32 [ 0, %bb0 ], [ %i1.next, %bb5 ]
-; IVNEXT covers the uses of %i0 and %t0.
-; Therefore, %t0 has been removed.
-; The critical edge has been split.
-; CHECK-NEXT: br i1 false, label %bb2, label %[[LOOP1BB6:.+]]
loop1: ; preds = %bb5, %bb0
%i1 = phi i32 [ 0, %bb0 ], [ %i1.next, %bb5 ] ; <i32> [#uses=4]
%t0 = add i32 %i0, %i1 ; <i32> [#uses=1]
br i1 false, label %bb2, label %bb6
-; CHECK: bb2:
-; Critical edge split.
-; CHECK-NEXT: br i1 true, label %[[BB2BB6:[^,]+]], label %bb5
bb2: ; preds = %loop1
br i1 true, label %bb6, label %bb5
-; CHECK: bb5:
-; CHECK-NEXT: %i1.next = add i32 %i1, 1
-; CHECK-NEXT: br i1 true, label %[[BB5BB6:[^,]+]], label %loop1
bb5: ; preds = %bb2
%i1.next = add i32 %i1, 1 ; <i32> [#uses=1]
br i1 true, label %bb6, label %loop1
-; bb5 to bb6 split basic block.
-; CHECK: [[BB5BB6]]:
-; CHECK-NEXT: [[INITIALVAL:%[^ ]+]] = add i32 [[IVNEXT]], %i1.next
-; CHECK-NEXT: br label %[[SPLITTOBB6:.+]]
-
-; bb2 to bb6 split basic block.
-; CHECK: [[BB2BB6]]:
-; CHECK-NEXT: br label %[[SPLITTOBB6]]
-
-; Split basic blocks to bb6.
-; CHECK: [[SPLITTOBB6]]:
-; CHECK-NEXT: [[INITP8:%[^ ]+]] = phi i32 [ [[INITIALVAL]], %[[BB5BB6]] ], [ undef, %[[BB2BB6]] ]
-; CHECK-NEXT: [[INITP9:%[^ ]+]] = phi i32 [ undef, %[[BB5BB6]] ], [ %i1, %[[BB2BB6]] ]
-; CHECK-NEXT: br label %bb6
-
-; CHECK: [[LOOP1BB6]]:
-; CHECK-NEXT: br label %bb6
-
-; CHECK: bb6:
-; CHECK-NEXT: %p8 = phi i32 [ undef, %[[LOOP1BB6]] ], [ [[INITP8]], %[[SPLITTOBB6]] ]
-; CHECK-NEXT: %p9 = phi i32 [ %i1, %[[LOOP1BB6]] ], [ [[INITP9]], %[[SPLITTOBB6]] ]
-; CHECK-NEXT: unreachable
bb6: ; preds = %bb5, %bb2, %loop1
%p8 = phi i32 [ %t0, %bb5 ], [ undef, %loop1 ], [ undef, %bb2 ] ; <i32> [#uses=0]
%p9 = phi i32 [ undef, %bb5 ], [ %i1, %loop1 ], [ %i1, %bb2 ] ; <i32> [#uses=0]
More information about the llvm-commits
mailing list