[PATCH] D143248: Emit CFI directives in epilogue and enable CFIFixup pass for RISC-V.

[Varun Kumar E via Phabricator via llvm-commits]

varunkumare99 added a comment.

In D143248#4199929 <https://reviews.llvm.org/D143248#4199929>, @asb wrote:

> In D143248#4128698 <https://reviews.llvm.org/D143248#4128698>, @varunkumare99 wrote:
>
>> In D143248#4122933 <https://reviews.llvm.org/D143248#4122933>, @asb wrote:
>>
>>> Hi Varun - thanks for filing bug #60698 <https://github.com/llvm/llvm-project/issues/60698> to help track this issue, and for noticing that there should now be some upstream support for cfi_remember_state and cfi_restore_state.
>>>
>>> The first question that comes to my mind is what degree of testing you've done with this?
>>
>> Hi Alex,
>> the patch updates over 500 testcases for RISCV(as it adds cfi info the epilogue), which results in a patch of over 30M. Due to which I'm not able to upload.
>
>
>
> In D143248#4128698 <https://reviews.llvm.org/D143248#4128698>, @varunkumare99 wrote:
>
>> In D143248#4122933 <https://reviews.llvm.org/D143248#4122933>, @asb wrote:
>>
>>> Hi Varun - thanks for filing bug #60698 <https://github.com/llvm/llvm-project/issues/60698> to help track this issue, and for noticing that there should now be some upstream support for cfi_remember_state and cfi_restore_state.
>>>
>>> The first question that comes to my mind is what degree of testing you've done with this?
>>
>> Hi Alex,
>> the patch updates over 500 testcases for RISCV(as it adds cfi info the epilogue), which results in a patch of over 30M. Due to which I'm not able to upload.
>
> Sorry for not getting back on this. I was thinking more about real-world testing rather than just test case changes.

Hi Alex,
I have tested it with Eigen and RangeV3 test-suite. They have passed with no failures.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143248/new/

https://reviews.llvm.org/D143248