[PATCH] D142888: [compiler-rt] Fix building GWPASAN on ARM

Fri Mar 24 02:43:34 PDT 2023

DavidSpickett added a comment.

> Do you have CMake commands that scudo causes build breakage on Armv7?

See the commit message and linked issue, I'm not sure how to reduce those to just scudo itself.

> Even if the build is fixed, scudo is likely never tested on AArch32.

I'm not even sure what scudo is exactly. I have a vague idea that it is used for something in Android and that still supports Armv7, doesn't it? I suppose if it did you (Google) would be testing that yourselves anyway. Do we have a list of known users?

None of our bots have been building it. This one https://github.com/llvm/llvm-zorg/blob/e3a5b28f7fc6af8820441f0f11c6cded87f18acf/buildbot/osuosl/master/config/builders.py#L431 did but due to https://github.com/llvm/llvm-project/issues/38038. I don't know if that is still a problem.

How about we:

- Land this.
- Investigate the linked bug.
- If it's still a problem we disable scudo for Arm 32 bit.
- Otherwise we'll re-enable testing on that bot.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142888/new/

https://reviews.llvm.org/D142888