[PATCH] D146790: [X86][NFC]Remove dead code in X86ISelLowering.cpp

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 01:36:43 PDT 2023


XinWang10 created this revision.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
XinWang10 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Look at the code in X86ISelLowering.cpp line 15579, when NumV2Elements == 0,
it has been handled in that scope, and will not move to the line 15612.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146790

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp


Index: llvm/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -15609,10 +15609,6 @@
           lowerShuffleAsShift(DL, MVT::v4i32, V1, V2, Mask, Zeroable, Subtarget,
                               DAG, /*BitwiseOnly*/ false))
     return Shift;
-  if (!Subtarget.preferLowerShuffleAsShift() && NumV2Elements == 0)
-    if (SDValue Rotate =
-            lowerShuffleAsBitRotate(DL, MVT::v4i32, V1, Mask, Subtarget, DAG))
-      return Rotate;
 
   // There are special ways we can lower some single-element blends.
   if (NumV2Elements == 1)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146790.507994.patch
Type: text/x-patch
Size: 685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230324/e71c52ff/attachment.bin>


More information about the llvm-commits mailing list