[PATCH] D145962: [lld] Fill .text section gaps with INT3 only on x86 targets.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 01:31:58 PDT 2023


mstorsjo added inline comments.


================
Comment at: lld/test/COFF/gaps-fill.test:38
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-windows %t.dir/x86_64-dllmain.s -o %t.dir/x86_64-dllmain.obj
+# RUN: llvm-mc -filetype=obj -triple=x86_64-windows %t.dir/x86_64-p4sym.s -o %t.dir/x86_64-p4sym.obj
----------------
mstorsjo wrote:
> chapuni wrote:
> > Does it work if only aarch64 is configured?
> Right, this probably needs to have `x86` added to the `REQUIRES` line.
I pushed a fix for this now, in 09aa3f7bb54bf7f35809d3abfdf9f6a679ba1003.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145962/new/

https://reviews.llvm.org/D145962



More information about the llvm-commits mailing list