[PATCH] D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:38105-38106
+    const APInt &Imm = cast<ConstantSDNode>(Op.getOperand(1))->getAPIntValue();
+    APInt Val = Known2.Zero;
+    Val.flipAllBits();
+    // Compute the known zero bits if we don't have to worry about overflow.
----------------
You can write this as `~Known2.Zero` or `Known2.getMaxValue()`. But I agree with @craig.topper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146787/new/

https://reviews.llvm.org/D146787