[PATCH] D146753: [llvm-readobj] Include section information in summary

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

The information about the total size of the sections might be misleading because it does not take into account possible gaps between them.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:7771-7790
   std::vector<EnumEntry<unsigned>> FlagsList =
       getSectionFlagsForTarget(this->Obj.getHeader().e_ident[ELF::EI_OSABI],
                                this->Obj.getHeader().e_machine);
   for (const Elf_Shdr &Sec : cantFail(this->Obj.sections())) {
     ++TotalSections;
     TotalSize += Sec.sh_size;
     if (Sec.sh_flags & SHF_ALLOC) {
----------------
It looks like you forget to include the actual patch in the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146753/new/

https://reviews.llvm.org/D146753