[PATCH] D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/vselect-post-combine.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-pc-windows-msvc -mattr=+avx2 | FileCheck %s --check-prefix=AVX2
+
----------------
pengfei wrote:
> xiangzhangllvm wrote:
> > pengfei wrote:
> > > This problem is not limited to Windows. Linux has the some problem if passing a ptr and load it to `<32 x i8>`.
> > Yes, I tended to rm windows then I found it is not triggered, duo to the previous optimization difference.
> The difference first comes from ABI, so you can remove it by
> ```
> define ptr @test_mul(ptr %0) {
> %vecinit.i.i.i.i.i92 = load <32 x i8>, ptr %0
> ```
Sorry, there is a delay for me to see this comment, I have update it : ), the test options is mainly to trigger the combine, now we can trigger it. Can we go on now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146683/new/

https://reviews.llvm.org/D146683