[PATCH] D146543: [Coroutines] Look for dbg.declare for temp spills

Thu Mar 23 19:06:54 PDT 2023

ChuanqiXu added a comment.

In D146543#4217194 <https://reviews.llvm.org/D146543#4217194>, @weiwang wrote:

> In D146543#4215777 <https://reviews.llvm.org/D146543#4215777>, @ChuanqiXu wrote:
>
>>> Does your downstream patch address the same issue? Maybe we can consolidate here.
>>
>> Oh, not exactly. It looks like you're saving the debug information under O0. While we're trying to save the debug information within optimization, which might not be so natural. And it looks like the problem occurs within opaque pointer and our downstream compiler didn't start to use opaque pointer yet. So in another word, this should be regression bug if I understand things correctly.
>
> Yeah, we generally use `-O0` for better debugging experiences. The issue was first reported from our internal release, which is based on clang-12, so I think it exists before and after opaque pointer. My plan is to fix upstream and then backport.

Got it. But let's  first try to handle it in `coro::salvageDebugInfo()` to make the code smell better.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146543/new/

https://reviews.llvm.org/D146543