[PATCH] D146744: [WebAssembly] Redesign DebugValueManager

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp:217
+// BB, 'Insert' should be below 'Def'; if they are in different BBs, 'Insert'
+// should be in one of 'Def's BBs successors for this work for DBG_VALUEs. Def
+// will be sunk regardless of the location.
----------------



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp:296
+// same BB, 'Insert' should be below 'Def'; if they are in different BBs,
+// 'Insert' should be in one of 'Def's BBs successors for this work for
+// DBG_VALUEs. Def will be cloned regardless of the location.
----------------



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp:297
+// 'Insert' should be in one of 'Def's BBs successors for this work for
+// DBG_VALUEs. Def will be cloned regardless of the location.
+//
----------------



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:32
   Register CurrentReg;
+  SmallVector<MachineInstr *, 1> getSinkableDebugValues(MachineInstr *Insert);
 
----------------
IIRC `SmallVectorImpl<MachineInstr *>` is preferred over an explicit size for parameters, since any size would work.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:40
+  void sink(MachineInstr *Insert);
+  // Clone 'Def', and also clone its eligible DBG_VALUEs to the place before
+  // 'Insert'.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146744/new/

https://reviews.llvm.org/D146744