[PATCH] D142888: [compiler-rt] Fix building GWPASAN on ARM

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.



In D142888#4217880 <https://reviews.llvm.org/D142888#4217880>, @omjavaid wrote:

> Hi I was wondering if  we could fast track merge of this patch into LLVM main and 16.0.0 release branch. This patch fixes LLVM 16.0.0 release build for armv7 Linux and release is waiting on this patch to be merged.
>
> Apparently patch looks in good shape so I was wondering if any one of the reviewers can press the accept button if there are no further objections.

Do you have CMake commands that scudo causes build breakage on Armv7?

Even if the build is fixed, scudo is likely never tested on AArch32.  I suggest that we do the following for https://github.com/llvm/llvm-project/tree/release/16.x

  --- i/compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake
  +++ w/compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake
  @@ -69,7 +69,7 @@ set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64}
       ${HEXAGON} ${LOONGARCH64})
   set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64}
       ${HEXAGON})
  -set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
  +set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}
       ${MIPS32} ${MIPS64} ${PPC64} ${HEXAGON} ${LOONGARCH64} ${RISCV64})
   if(APPLE)
   set(ALL_XRAY_SUPPORTED_ARCH ${X86_64})

Likewise, I am unsure mips32/hexagon are really supported for scudo. Perhaps we can remove the two entries as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142888/new/

https://reviews.llvm.org/D142888