[PATCH] D146759: Declaration fragments for properties include additional property attributes that were not specified in the sources proposed solution

[Usman Akinyemi via Phabricator via llvm-commits]

Unique_Usman created this revision.
Unique_Usman added reviewers: zixuw, dang, samtebbs.
Herald added a reviewer: ributzka.
Herald added a project: All.
Unique_Usman requested review of this revision.

if (Attributes == ObjCPropertyAttribute::kind_noattr) { //I changed the != to == as I guess we only want to generate the attribute only if it is the same as the one specified in the source.

Kindly review it, and I will  be glad to review it back if I am wrong.

Thank you.


https://reviews.llvm.org/D146759

Files:
  clang/lib/ExtractAPI/DeclarationFragments.cpp


Index: clang/lib/ExtractAPI/DeclarationFragments.cpp
===================================================================
--- clang/lib/ExtractAPI/DeclarationFragments.cpp
+++ clang/lib/ExtractAPI/DeclarationFragments.cpp
@@ -624,7 +624,8 @@
 
   const auto Attributes = Property->getPropertyAttributes();
   // Build the attributes if there is any associated with the property.
-  if (Attributes != ObjCPropertyAttribute::kind_noattr) {
+
+  if (Attributes == ObjCPropertyAttribute::kind_noattr) { //I changed the != to == as I guess we only want to generate the attribute only if it is the same as the one specified in the source 
     // No leading comma for the first attribute.
     bool First = true;
     Fragments.append(" (", DeclarationFragments::FragmentKind::Text);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146759.507874.patch
Type: text/x-patch
Size: 777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230323/97de2957/attachment.bin>