[PATCH] D146747: [RISCV] Model select and insertsubvector shuffle kinds

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 14:04:44 PDT 2023


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM - once all the earlier patches have been approved.

Note that you explicitly do *not* need to add the slideup only case to the costing for this LGTM.  Doing so is a good idea, but this is much closer than the current code and is thus a worthwhile stepping stone regardless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146747/new/

https://reviews.llvm.org/D146747



More information about the llvm-commits mailing list