[PATCH] D146534: [llvm-nm] Print EC symbol map.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 11:50:16 PDT 2023


efriedma added a comment.

> I wasn't sure what to do when the map is invalid. We could treat it as an error in Archive constructor, but I decided to just ignore the map instead assuming that the archive may still be useful.

Actually, hmm... maybe we should reject in this case.  I mean, the archive might be "useful" in the sense that it contains interesting object files someone might want to use, but what's the linker supposed to do if symbol map is malformed?  If we eat the error, it'll just assume there just aren't any symbols, so it'll produce weird link errors or an invalid executable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146534/new/

https://reviews.llvm.org/D146534



More information about the llvm-commits mailing list