[PATCH] D146534: [llvm-nm] Print EC symbol map.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 10:54:21 PDT 2023


efriedma added inline comments.


================
Comment at: llvm/lib/Object/Archive.cpp:987
+      return false;
+    StringIndex = Map.find('\0', StringIndex) + 1;
+    if (StringIndex > Map.size())
----------------
StringRef::find() returns npos (i.e. -1) on failure, so I don't think this does what you want.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146534/new/

https://reviews.llvm.org/D146534



More information about the llvm-commits mailing list