[PATCH] D146743: [WebAssembly] Tidy up DebugValueManager

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 10:52:28 PDT 2023


aheejin created this revision.
aheejin added a reviewer: dschuff.
Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100.
Herald added a project: All.
aheejin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Misc. cleanups for `WebAssemblyDebugValueManager`.

- Use `Register` for registers
- Simpler for loop iteration
- Rename a variable
- Reorder methods
- Reduce `SmallVector` size for `DBG_VALUE`s to 1; one def usually have a single `DBG_VALUE` attached to it in most cases
- Add a few more lines of comments


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146743

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146743.507816.patch
Type: text/x-patch
Size: 3935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230323/92afe230/attachment.bin>


More information about the llvm-commits mailing list