[PATCH] D146720: [AMDGPU][printf] Run AMDGPUPrintfRuntimeBindingPass in -O0

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 09:48:34 PDT 2023


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM, thanks I noticed this when I was fixing printf recently but forgot to fix this part



================
Comment at: llvm/test/CodeGen/AMDGPU/opt-pipeline.ll:18
+;GCN-O0-NEXT: Running pass: AlwaysInlinerPass on [module]
+;GCN-O0-NEXT: Running analysis: ProfileSummaryAnalysis on [module]
+;GCN-O0-NEXT: Running pass: CoroConditionalWrapper on [module]
----------------
jmmartinez wrote:
> I have the feeling that I should remove analysis and analysis invalidations from the list.
Depends, do theses passes actually do anything? I don’t know what CoroConditionalWrappper does 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146720/new/

https://reviews.llvm.org/D146720



More information about the llvm-commits mailing list