[PATCH] D144596: [lld] Support separate native object file path in --thinlto-prefix-replace

Ivan Tadeu Ferreira Antunes Filho via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 09:42:20 PDT 2023


itf marked 5 inline comments as done.
itf added inline comments.


================
Comment at: llvm/include/llvm/LTO/LTO.h:229
                                           std::string NewPrefix,
+                                          std::string NewLinkObjectPrefix,
                                           bool ShouldEmitImportsFiles,
----------------
tejohnson wrote:
> MaskRay wrote:
> > `NewLinkObjectPrefix` refers to the ELF relocatable object file path. Is there a better parameter name to reflect that than `NewLinkObjectPrefix`? @tejohnson 
> Maybe FinalObjectPrefix ?
Would FinalObjectPrefix not be confused with being the prefix of the final executable/lib created at the end of the final linking step, where are these "link objects" get linked together?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144596/new/

https://reviews.llvm.org/D144596



More information about the llvm-commits mailing list