[PATCH] D146158: [FuncSpec] Track the return values of specializations.

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 09:32:37 PDT 2023


labrinea updated this revision to Diff 507765.
labrinea added a comment.

I found a bug in the previosu revision. When invalidating return instructions we shouldn't be looking for their lattice state in the value map, but in the tracked returns map instead. Then we should invalidate the users of the function which corresponds to that return instruction. I've changed the unit test to verify this scenario.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146158/new/

https://reviews.llvm.org/D146158

Files:
  llvm/include/llvm/Transforms/Utils/SCCPSolver.h
  llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
  llvm/lib/Transforms/Utils/SCCPSolver.cpp
  llvm/test/Transforms/FunctionSpecialization/function-specialization-constant-expression.ll
  llvm/test/Transforms/FunctionSpecialization/specialize-multiple-arguments.ll
  llvm/test/Transforms/FunctionSpecialization/track-return.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146158.507765.patch
Type: text/x-patch
Size: 15077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230323/ddaca51f/attachment.bin>


More information about the llvm-commits mailing list