[PATCH] D146724: [mlir][MemRef] Add patterns to extract address computations

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM, make sense to keep the interface work for later.

One note though, we also need those on vector.transfer soonish.



================
Comment at: mlir/include/mlir/Dialect/MemRef/Transforms/Passes.h:65
+/// ```
+void populateExtractAddressComputationsPatterns(RewritePatternSet &patterns);
+
----------------
Similary to https://reviews.llvm.org/D146624 we want all these populate to live in Transform/Transforms.h


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/CMakeLists.txt:7
   EmulateWideInt.cpp
+  ExtractAddressComputations.cpp
   FoldMemRefAliasOps.cpp
----------------
It would be nice to find a name that somehow ties these logically to  FoldMemRefAliasOps.cpp but I odn't have a better suggestion atm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146724/new/

https://reviews.llvm.org/D146724