[PATCH] D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges

Thu Mar 23 06:51:32 PDT 2023

dstuttard added a comment.

In D144503#4206820 <https://reviews.llvm.org/D144503#4206820>, @dstuttard wrote:

>>> I note from an earlier comment that updating VS2022 with latest patches solved this issue for @srj 
>>> But is the issue similar for the minimum required version of MSVC (currently Visual Studio 2019 / v16.0 )??
>>
>> It passed across all windows buildbots, which includes VS 2019. Example: https://lab.llvm.org/buildbot/#/builders/13/builds/33254
>
> I think that build bot is using 1929 (which is VS2019 16.10 ??) I get confused by the different ways the versions are described :(
> The minimum required is v16.0 - which is 1920 I think.
>
> Needless to say, we're seeing the same build error. I'll do some digging and see if updating to a newer VS2019 fixes the issue for us too (although if it does I guess the min required version will need updating).

Apologies - I was mistaken. We are actually seeing the issue with VS 2022 and not VS2019. I've done a bit more investigation and have discovered:
19.29.30133 (VS 2019 16.11.0) - works
19.31.31107 (VS2022 17.1) - fails
19.34.31933 (VS2022 17.4) - works

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144503/new/

https://reviews.llvm.org/D144503