[PATCH] D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12247
+      (N0->getOpcode() == ISD::VSELECT &&
+       TLI.getOperationAction(ISD::VSELECT, VT) != TargetLowering::Legal))
     return SDValue();
----------------
LuoYuanke wrote:
> Check "Level <= AfterLegalizeVectorOps" instead?
Maybe changed as below.

```
  if ((N0->getOpcode() == ISD::VSELECT && Level > AfterLegalizeVectorOps &&
       TLI.getOperationAction(ISD::VSELECT, VT) != TargetLowering::Legal
       ))
    return SDValue();
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146683/new/

https://reviews.llvm.org/D146683