[PATCH] D143465: [LoopVectorize] Vectorize the reduction pattern of integer min/max with index.

Mel Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 23 06:13:57 PDT 2023


Mel-Chen added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IVDescriptors.h:379
+
+  PHINode *UserRecurPhi = nullptr;
+
----------------
Mel-Chen wrote:
> fhahn wrote:
> > It would be helpful to document how the new system of recurrences depending on other recurrences would work I think, possibly also with an explanation of the whole approach in the patch description.
> Sure. I will document the whole approach. and update in the summary tomorrow.
> Quickly explain the function of `UserRecurPhi` . The purpose of `UserRecurPhi` is to allow the recurrence to be used in the loop (loop internal use), and to ensure that the user is also a recurrence. `UserRecurPhi` will record the candidate user recurrence phi, and `UserRecurKind` will recored the excepted user recurrence kind. Currently I'm limiting candidates to one, but it should be possible to have more than one.
Too busy today. The document will be available in next week.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143465/new/

https://reviews.llvm.org/D143465



More information about the llvm-commits mailing list