[PATCH] D144959: [AMDGPU][AsmParser][NFC] Refine immediate operand definitions.
Dmitry Preobrazhensky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 23 05:40:47 PDT 2023
dp added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructions.td:137
+ string printer = "print"#name> : Operand<type> {
+ AsmOperandClass ParserMatchClass = ImmOperandClass<name, optional>;
+ let PrintMethod = printer;
----------------
This redefinition is unnecessary, 'let' would suffice.
================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:750
-def smrd_literal_offset : NamedOperandU32<"SMRDLiteralOffset",
- NamedMatchClass<"SMRDLiteralOffset">> {
- let OperandType = "OPERAND_IMMEDIATE";
-}
+def smrd_literal_offset : ImmOperand<i32, "SMRDLiteralOffset">;
----------------
Shouldn't this operand be optional?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144959/new/
https://reviews.llvm.org/D144959
More information about the llvm-commits
mailing list