[PATCH] D146683: [DAG Combine] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:1043
+      assert(N->getValueType(0).getVectorElementType() != MVT::i16 &&
+             "We can't replace VSELECT with BLENDV in vxi16!");
       SDValue Blendv =
----------------
vXi16?


================
Comment at: llvm/test/CodeGen/X86/vselect-post-combine.ll:4
+
+define ptr @test_mul(<32 x i8> %vecinit.i.i.i.i.i92) {
+; AVX2-LABEL: test_mul:
----------------
Can we simplify the variable name?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146683/new/

https://reviews.llvm.org/D146683