[PATCH] D146637: [InstCombine] Try to recognize bswap pattern when calling funnel shifts

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1795
         return CallInst::Create(Bswap, { Op0 });
       }
     }
----------------
nikic wrote:
> This code block can probably be dropped now, if it's already handled by the preceding?
Or you can move your code after the existing one, which will avoid the regression in fshl_mask_args_same2. It shouldn't be necessary to handle this specially, but clearly we're missing a zext(shl(trunc)) fold.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146637/new/

https://reviews.llvm.org/D146637