[PATCH] D146629: [SimplifyCFG][LICM] Preserve nonnull, range and align metadata when speculating

Thu Mar 23 00:01:18 PDT 2023

StephenFan added a comment.

In D146629#4213401 <https://reviews.llvm.org/D146629#4213401>, @jdoerfert wrote:

> This is valid, I think.
> That said, I went to try what could go wrong and it was easy.
> At least early-cse is buggy so this will cause issues until those bugs are fixed:
> https://godbolt.org/z/Tz98hYa9E
>
> FWIW, instcombine gets it right regardless of the order. Might be luck or logic to properly merge the attributes.

Does it seem that we even haven't called combineMetadata in early-cse?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146629/new/

https://reviews.llvm.org/D146629