[PATCH] D144356: [XCOFF] support the ref directive for object generation.

Wed Mar 22 22:12:32 PDT 2023

shchenz added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp:280
+  return StringSwitch<std::optional<MCFixupKind>>(Name)
+      .Case("R_REF", (MCFixupKind)PPC::fixup_ppc_nofixup)
+      .Default(std::nullopt);
----------------
Esme wrote:
> shchenz wrote:
> > nit: although we don't have user for other fixup kinds, for functionality complete, could we add other cases as well? This is what other targets do.
> I don't really agree with adding other cases that are not used in this patch, because we will neither assurance its features for these cases nor test them.
> I found that BFD_RELOC_* relocations are supported in other target, for example D118136, and if necessary, we can also support it for AIX, but it should not be in this patch. What do you think?
OK

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144356/new/

https://reviews.llvm.org/D144356