[PATCH] D142699: [AsmParser] Avoid instantiating LLVMContext if not needed. NFC

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 20:08:46 PDT 2023


yrouban added a comment.

@jsilvanus , @arsenm, please take a look.

In D142699#4212525 <https://reviews.llvm.org/D142699#4212525>, @jsilvanus wrote:

> @arsenm are you OK with this now?

@jsilvanus, do you mind if I land the patch? I believe @arsenm just misunderstood the change. The given context is not recycled. The local context is recycled as it used to be. The only change is that the new local context is created only if it is really needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142699/new/

https://reviews.llvm.org/D142699



More information about the llvm-commits mailing list