[PATCH] D146452: [AutoFDO] Use flattened profiles for profile staleness metrics

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 18:08:55 PDT 2023


wenlei added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:1353-1356
+    // TotalSamples might not be equal to the sum of all samples from
+    // BodySamples and CallsiteSamples. So here we use "TotalSamples =
+    // Original_TotalSamples - All_of_Callsite_TotalSamples +
+    // All_of_Callsite_HeadSamples" to compute the new TotalSamples.
----------------
Is the total samples populated this way going to be consistent with total samples from profiles generated directly from llvm-profgen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146452/new/

https://reviews.llvm.org/D146452



More information about the llvm-commits mailing list