[PATCH] D146663: [RISCV] Add .insn support compressed formats.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1569
+
+  Error(S, "opcode must be in the range [0, 2]");
+  return MatchOperand_ParseFail;
----------------
craig.topper wrote:
> jrtc27 wrote:
> > craig.topper wrote:
> > > jrtc27 wrote:
> > > > This is a slightly weird error to give in this case... then again so is the non-C equivalent by the looks of it
> > > Why is it weird?
> > C0 through C2 aren't numbers, this kind of implies only 0 through 2 are accepted, not also C0 through C2.
> Do you want me to say "opcode must be a valid opcode name or an immediate in the range [0, 2]"?
> 
> If you've figured out the format for these directives you're probably also looking at the opcode list.
That sounds fine to me, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146663/new/

https://reviews.llvm.org/D146663