[PATCH] D142666: [DAGCombiner] Transform ABS(X) eq/ne 0/IntMin -> X eq/ne 0/IntMIn

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D142666#4213821 <https://reviews.llvm.org/D142666#4213821>, @RKSimon wrote:

> In D142666#4213794 <https://reviews.llvm.org/D142666#4213794>, @goldstein.w.n wrote:
>
>> In D142666#4212405 <https://reviews.llvm.org/D142666#4212405>, @RKSimon wrote:
>>
>>> @goldstein.w.n reverse-ping - whats the plan for this patch?
>>
>> @RKSimon does this show up in any codegen that went throw the middle-end?
>
> There isn't that much in DAG that generates ABS nodes - foldAndOrOfSETCC is the closest to this I suppose?

Yeah, and the pattern that would generate ABS IntMin/0 there are also handled by the middle end.
If a case were this is needed comes up, I can resubmit, but for now just seems like unnecessary codes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142666/new/

https://reviews.llvm.org/D142666