[PATCH] D146327: [ArgPromotion] Remove dead code produced by removing dead arguments

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 11:44:40 PDT 2023


nikic added a comment.

This looks good to me, but could you please pre-commit the new tests with baseline check lines, and then rebase this patch so that only the test diff is visible?



================
Comment at: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp:261
         }
+      } else { // ArgsToPromote.count(&*I) && I->use_empty()
+        assert(ArgsToPromote.count(&*I) && I->use_empty());
----------------
Don't think we need this comment given the assert on the next line...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146327/new/

https://reviews.llvm.org/D146327



More information about the llvm-commits mailing list