[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:365
-      const FDE &fde = cast<ObjFile>(d->getFile())->fdes[d->unwindEntry];
-      cu.functionLength = fde.funcLength;
-      cu.personality = fde.personality;
----------------
I believe we still need to store functionLength, otherwise the computation of cueEndBoundary in later code will be wrong.


================
Comment at: llvm/lib/MC/MCContext.cpp:934
+    return TargetOptions->EmitCompactUnwindNonCanonical;
+  // FIXME(oontvoo): Flip this to false in up-comping patch.
+  return true;
----------------
IMO, we should flip this to start with -- I don't think there's a real point in doing it separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144999/new/

https://reviews.llvm.org/D144999