[PATCH] D145836: [MemProf] Context disambiguation cloning pass [patch 1b/3]

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp:1379
+  if (ExportToDot)
+    exportToDot("prestackupdate");
+
----------------
tejohnson wrote:
> snehasish wrote:
> > Should we give the ThinLTO version a different filename?
> good idea will do
Actually, other than in this location, it is trickier to do this as the calls to exportToDot are from the common code. I am not sure it is worth it to provide special derived class handling just to get a different name for the dot files (for the tests they will be in different directories anyway).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145836/new/

https://reviews.llvm.org/D145836