[PATCH] D146567: Assert in codesize.py that we have exactly one of size..text and size.__text
    Azharuddin Mohammed via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Mar 22 11:28:05 PDT 2023
    
    
  
azharudd accepted this revision.
azharudd added a comment.
This revision is now accepted and ready to land.
One nit, LGTM otherwise. Thanks!
================
Comment at: litsupport/modules/codesize.py:40
                     metrics['size.%s' % name] = val
+                    # Darwin and GNU produce different output here. Check that
+                    # we have exactly one of the valid outputs.
----------------
The output comes from `llvm-size`. Can we please update the comment to reflect that.
Repository:
  rT test-suite
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146567/new/
https://reviews.llvm.org/D146567
    
    
More information about the llvm-commits
mailing list