[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/docs/ReleaseNotes.rst:109
+  option, and is not supported with ``-fno-data-sections``. The option is
+  available on AIX.
 
----------------
s/available/only supported/


================
Comment at: llvm/test/CodeGen/PowerPC/aix64-xcoff-roptr.ll:17
+ at _ZL1p = internal constant i64 ptrtoint (ptr @_ZL1p to i64), align 8
+;CHECK:         .csect _ZL1p[RO],3
+;CHECK-NEXT:    .lglobl	_ZL1p[RO]
----------------
`;CHECK` => `; CHECK`


================
Comment at: llvm/test/CodeGen/PowerPC/aix64-xcoff-roptr.ll:21
+;CHECK-NEXT:    .vbyte	8, _ZL1p[RO]
+;OBJ-DAG: {{([[:xdigit:]]{16})}} l .text {{([[:xdigit:]]{16})}} (idx: {{[0-9]+}}) _ZL1p[RO]
+ at q = thread_local constant ptr @_ZL1p, align 8
----------------
Replace `{{[0-9]+}}` with `[[#]]` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189