[PATCH] D146452: [AutoFDO] Use flattened profiles for profile staleness metrics
Lei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 22 11:15:48 PDT 2023
wlei added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2088
+
+ if (FunctionSamples::ProfileIsCS) {
+ for (const auto &I : Reader.getProfiles())
----------------
hoy wrote:
> Does it make sense to incorporate the CS path into `ProfileConverter::flattenProfile`?
Good idea, done! I just found it needs to clear the context to make llvm-profdata sample writer pass the context check. Also added the llvm-profdata test for full cs profile.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146452/new/
https://reviews.llvm.org/D146452
More information about the llvm-commits
mailing list