[PATCH] D146641: [JITLink] Introduce target flags for Symbol and prepare ObjectLinkingLayer to account for them

Wed Mar 22 10:03:45 PDT 2023

lhames accepted this revision.
lhames added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:675
   size_t Size = 0;
+  TargetFlagsType TargetFlags;
 };
----------------
sgraenitz wrote:
> Conceptually, this should be generic and allow targets to store a variety of flags, but for the time being I guess `ThumbSymbol` will be the only flag we have upstream.
> 
> Anyway, non of these data structures are serialized, so can change it any time. I could take one more bit away from Offset to reduce memory pressure. (Or Two?) What do you think?
Yep -- we're free to modify link graph internals at will. I think it's fine to steal another bit from Offset for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146641/new/

https://reviews.llvm.org/D146641