[PATCH] D146595: [clang] Add clang trampoline attribute

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

So this attribute will lower into a `DW_AT_trampoline("target_func_name")` attribute on the `DW_TAG_subprogram` of the function definition?

The debug info parts LGTM. It would be nice to hear some extra confirmation that we're fine with this specific attribute name.



================
Comment at: llvm/include/llvm/IR/DIBuilder.h:802
+        DITemplateParameterArray TParams = nullptr,
+        DITypeArray ThrownTypes = nullptr, StringRef TargetFuncName = "");
 
----------------
Why did you need to add this? Does `flang` use a different createMethod() method?
I assume yes, since it the doxygen comment explicitly calls out C++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146595/new/

https://reviews.llvm.org/D146595