[PATCH] D143537: [Object][NFC] Factor out computeHeadersSize.

[Jacek Caban via Phabricator via llvm-commits]

jacek added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:697
   uint64_t LastMemberEndOffset =
-      isAIXBigArchive(Kind) ? sizeof(object::BigArchive::FixLenHdr) : 8;
+      isAIXBigArchive(Kind) ? sizeof(object::BigArchive::FixLenHdr) : 0;
   uint64_t LastMemberHeaderOffset = LastMemberEndOffset;
----------------
efriedma wrote:
> It's not obvious to me what this constant 8 was supposed to mean, or why it's changing to zero.
8 meant strlen("!<arch>\n"), I changed it to 0 because computeHeadersSize now takes care of it. I will change bug archive code path to be more similar to other formats, I think it will make it easier to follow.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143537/new/

https://reviews.llvm.org/D143537