[PATCH] D146212: [AArch64] Use NEON's tbl1 for 16xi8 and 8xi8 build vector with mask.

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added a comment.

> @dmgreen Okay, I rebased onto main and submited via arc. I hope this did the right thing, but it doesn't look broken. I guess my mistake in the other patch was to create a merge commit instead of rebasing. For future reference, I'll just always squash into in commit.

I use arc a lot and rebase things frequently. What you did may not even be incorrect, but arc has a habit of doing crazy things for small mistakes. It's usually better to find a safe method rather than trying to understand why it did what it did.

I usually have the patches that are in review in a branch. So if I want to rebase them onto main, I update main, checkout the branch. Then `git rebase main` to update them all. Then to update each review I interactive rebase back to each patch and run `arc diff` from there.

You can apply the same thing if you have a series of say 5 patches, and someone asks you to update patch 1 which means you have to change all the rest. Rebase back to patch 1, marking all the commits to edit. Do your changes, arc diff, then continue the rebase, fixing up each commit as you go and updating the reviews.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146212/new/

https://reviews.llvm.org/D146212