[PATCH] D146621: [sanitizer][win] Change cmdline check to allow double backslashs

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.

I'm not a windows expert, but looking at the references this seems ok. The check was introduced with D11791 <https://reviews.llvm.org/D11791>. Looks like there is one windows test of the symbolizer path, added with that patch (compiler-rt/test/asan/TestCases/Windows/report_after_syminitialize.cpp). Can you add a test that it accepts a double backslash path with this change (like that existing path, presumably we can error that it wasn't found, but it shouldn't get the removed check's error anymore)? Perhaps that existing test can just be tweaked to add the double backslash onto the provided symbolizer path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146621/new/

https://reviews.llvm.org/D146621