[PATCH] D143162: [AArch64] Add PredictableSelectIsExpensive feature for the Neoverse V1

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Hi sorry for the delay. This fell off my radar after some benchmarking failed and the reruns took a while. I think the results are probably fine overall. None of the changes I saw were very large and at least in some cases it was a small improvement.

I think it is worth adding FeaturePredictableSelectIsExpensive to all the cpus that have FeatureEnableSelectOptimize to keep them consistent. But maybe not Generic if it is not applicable to all cpus. We could think about combining FeaturePredictableSelectIsExpensive and FeatureEnableSelectOptimize into a single feature at some point, but it is probably useful to have them separate for the time being, in case we receive any reports of performance getting worse.

@SjoerdMeijer any opinion from your end?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143162/new/

https://reviews.llvm.org/D143162