[PATCH] D146212: [AArch64] Use NEON's tbl1 for 16xi8 and 8xi8 build vector with mask.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 04:57:42 PDT 2023


dmgreen added a comment.

In D146212#4209438 <https://reviews.llvm.org/D146212#4209438>, @lawben wrote:

> @dmgreen Thanks for the feedback. I've addressed the comments you made. I've renamed the method, as it does not require an `AND` anymore.
>
> re: update to base against main. I tried to merge the current main branch into another patch (using git) and completely broke my setup, i.e., `arc` is doing really weird things, trying to lint hundreds of files, etc. So I'm not sure what the correct way is to do this. Do you maybe have a pointer for me? This is my first patch, so I'm new to this setup.

I'm afraid I'm a bit of a luddite who just uploads patches manually into phabricator and doesn't use arc.  I usually use `git rebase -i` to squash patches into a single commit, and upload them from there. Maybe the same thing will help with arc?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146212/new/

https://reviews.llvm.org/D146212



More information about the llvm-commits mailing list