[PATCH] D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 04:27:12 PDT 2023


dmgreen added a comment.

Hi - sorry I must have misunderstood your last comment. I was under the impression that you were going to go and look into the other optimizations.

I don't think it is a good idea to change SDAG code generation (setOperationAction) in order to change the SLP cost model (getStoreMinimumVF). The setOperationAction isn't really valid on its own, considering we don't have a custom way of storing v4i8. It would be better to modify the costmodel directly through getStoreMinimumVF, either through the generic version or an AArch64 override.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145614/new/

https://reviews.llvm.org/D145614



More information about the llvm-commits mailing list