[llvm] 9bb96fd - [llvm] Use llvm::isNullConstant (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 22 00:31:54 PDT 2023
Author: Kazu Hirata
Date: 2023-03-22T00:31:48-07:00
New Revision: 9bb96fd87498a0bcf791e808ba2a7f1dc9209287
URL: https://github.com/llvm/llvm-project/commit/9bb96fd87498a0bcf791e808ba2a7f1dc9209287
DIFF: https://github.com/llvm/llvm-project/commit/9bb96fd87498a0bcf791e808ba2a7f1dc9209287.diff
LOG: [llvm] Use llvm::isNullConstant (NFC)
Added:
Modified:
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
llvm/lib/Target/AMDGPU/R600ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index 5cf9497069f78..a3667d9bd11b9 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -7386,8 +7386,7 @@ static SDValue getMemsetStores(SelectionDAG &DAG, const SDLoc &dl,
FrameIndexSDNode *FI = dyn_cast<FrameIndexSDNode>(Dst);
if (FI && !MFI.isFixedObjectIndex(FI->getIndex()))
DstAlignCanChange = true;
- bool IsZeroVal =
- isa<ConstantSDNode>(Src) && cast<ConstantSDNode>(Src)->isZero();
+ bool IsZeroVal = isNullConstant(Src);
unsigned Limit = AlwaysInline ? ~0 : TLI.getMaxStoresPerMemset(OptSize);
if (!TLI.findOptimalMemOpLowering(
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
index ac5e9d0986011..a08b0fb02e497 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
@@ -25,11 +25,7 @@ using namespace llvm;
namespace {
static inline bool isNullConstantOrUndef(SDValue V) {
- if (V.isUndef())
- return true;
-
- ConstantSDNode *Const = dyn_cast<ConstantSDNode>(V);
- return Const != nullptr && Const->isZero();
+ return V.isUndef() || isNullConstant(V);
}
static inline bool getConstantValue(SDValue N, uint32_t &Out) {
diff --git a/llvm/lib/Target/AMDGPU/R600ISelLowering.cpp b/llvm/lib/Target/AMDGPU/R600ISelLowering.cpp
index d361df26841c3..ad072cfe23b17 100644
--- a/llvm/lib/Target/AMDGPU/R600ISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/R600ISelLowering.cpp
@@ -953,10 +953,8 @@ SDValue R600TargetLowering::lowerADDRSPACECAST(SDValue Op,
unsigned SrcAS = ASC->getSrcAddressSpace();
unsigned DestAS = ASC->getDestAddressSpace();
- if (auto *ConstSrc = dyn_cast<ConstantSDNode>(Op.getOperand(0))) {
- if (SrcAS == AMDGPUAS::FLAT_ADDRESS && ConstSrc->isZero())
- return DAG.getConstant(TM.getNullPointerValue(DestAS), SL, VT);
- }
+ if (isNullConstant(Op.getOperand(0)) && SrcAS == AMDGPUAS::FLAT_ADDRESS)
+ return DAG.getConstant(TM.getNullPointerValue(DestAS), SL, VT);
return Op;
}
More information about the llvm-commits
mailing list