[PATCH] D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 22:45:39 PDT 2023


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-dwarfdump/ARM/aligned_line_tables.s:13-15
+// This test is based on a real example from ARM C/C++ Compiler.
+// It verifies llvm-dwarfdump is able to dump line tables even if they've been
+// placed at aligned offsets.
----------------
jhenderson wrote:
> FWIW, I'd use `////` here, much like I'd use `##` to distinguish it from test code. Same goes with other test comments later on.
`/// ` to distinguish non-CHECK-non-RUN comments should be fine :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143513/new/

https://reviews.llvm.org/D143513



More information about the llvm-commits mailing list