[PATCH] D146516: [RISCV][Zfa] Fix FROUND codegen bugs

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfa.td:201
 // fnearbyint is like frint but does not detect inexact conditions.
-def: Pat<(any_fnearbyint FPR32 : $rs1), (FROUND_S FPR32 : $rs1, 0b111)>;
+def: Pat<(any_fnearbyint FPR32: $rs1), (FROUND_S FPR32: $rs1, 0b111)>;
 
----------------
There shouldn't be a space after the `:` either


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfa.td:231
+def: Pat<(any_fceil FPR64 : $rs1), (FROUND_D FPR64 : $rs1, 0b011)>;
 def: Pat<(any_ftrunc FPR64 : $rs1), (FROUND_D FPR64 : $rs1, 0b001)>;
 
----------------
jrtc27 wrote:
> Can we give these names?
I will give them names in another patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146516/new/

https://reviews.llvm.org/D146516